Fix berglas exec on Windows#287
Open
rodrigopimentel wants to merge 1 commit into
Open
Conversation
syscall.Exec (execve) does not exist on Windows, causing berglas exec to fail with "not supported by windows" on all Windows builds. Replace syscall.Exec with os/exec.Command which is cross-platform and works on Linux, macOS, and Windows. The child process exit code is propagated to the caller.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
berglas execfails on Windows with"not supported by windows"becausesyscall.Exec(execve) does not exist on Windows.This replaces
syscall.Execwithos/exec.Command, which is cross-platform and works on Linux, macOS, and Windows. The child process exit code is propagated to the caller.Context
.goreleaser.yml(goos: ['darwin', 'linux', 'windows'])resolver.gohaschmodSupported = runtime.GOOS != "windows")berglas execis the only command broken on Windowssyscall.Execwas introduced in Switch to syscall/exec #172 to fix signal handling issues in k8s — this change preserves exit code propagation while restoring cross-platform supportFixes the Windows portion of #171.